Skip to content

Add devices by similarity#1554

Merged
edenhaus merged 1 commit into
devfrom
by-similarity-2604
Apr 23, 2026
Merged

Add devices by similarity#1554
edenhaus merged 1 commit into
devfrom
by-similarity-2604

Conversation

@edenhaus

@edenhaus edenhaus commented Apr 23, 2026

Copy link
Copy Markdown
Member

Fixes #1486

Copilot AI review requested due to automatic review settings April 23, 2026 21:28
@edenhaus

Copy link
Copy Markdown
Member Author

@copilot The model class is the file name. So check the open issues if we have implemented some devices for that open issues exists

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov

codecov Bot commented Apr 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.92%. Comparing base (fb64fe3) to head (4ed10fb).
⚠️ Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1554   +/-   ##
=======================================
  Coverage   94.92%   94.92%           
=======================================
  Files         156      156           
  Lines        6105     6105           
  Branches      350      350           
=======================================
  Hits         5795     5795           
  Misses        248      248           
  Partials       62       62           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot AI commented Apr 23, 2026

Copy link
Copy Markdown

@copilot The model class is the file name. So check the open issues if we have implemented some devices for that open issues exists

Checked all model class IDs (file names) against open issues. Found one match: issue #1486 ("Ecovacs GOAT A1600 LiDAR Pro Support") which explicitly mentions class e4gqia. That issue is resolved by the e4gqia.py symlink added in this PR — I've updated the PR description to close it. No other open issues were found for the remaining class IDs (3gwbbm, aadham, cgm9ex, m2nkyq, ss87ia, wwswjm).

@codspeed-hq

codspeed-hq Bot commented Apr 23, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 113 untouched benchmarks


Comparing by-similarity-2604 (4ed10fb) with dev (fb64fe3)

Open in CodSpeed

@edenhaus edenhaus merged commit 8980d8c into dev Apr 23, 2026
31 checks passed
@edenhaus edenhaus deleted the by-similarity-2604 branch April 23, 2026 21:54
@edenhaus edenhaus added the pr: new-feature PR, which adds a new feature label Apr 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: new-feature PR, which adds a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ecovacs GOAT A1600 LiDAR Pro Support

3 participants